On Thu, Aug 20, 2020 at 02:09:55PM -0700, Thirupathaiah Annapureddy wrote:
Hi Ryan,
Thanks for reviewing the patch. Please see my comment(s):
On 8/19/2020 7:06 PM, Ryan Chen wrote:
Hi
-----Original Message----- From: Thirupathaiah Annapureddy [mailto:thiruan@linux.microsoft.com] Sent: Thursday, August 20, 2020 8:16 AM To: u-boot@lists.denx.de Cc: Maxim Sloyko maxims@google.com; Marek Vasut marex@denx.de; ChiaWei Wang chiawei_wang@aspeedtech.com; Ryan Chen ryan_chen@aspeedtech.com Subject: Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target
Adding Ryan and Chiawei to the list.
On 8/17/2020 5:53 PM, Thirupathaiah Annapureddy wrote:
Include ast2500-evb.dtb for CONFIG_TARGET_EVB_AST2500 instead of for all aspeed targets.
There should not have to many Kconfig for ASPEED platform.
When you build U-Boot, you have to provide a platform specific defconfig as the target. ex: evb-ast2500_defconfig. defconfig specifies the platform specific device tree file. ex: CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"
I do not see any reason to make other device trees (ex: ast2600a0-evb.dtb) when we are building for evb-ast2500.
It keeps the Makefile logic clearer and makes future moves towards more platforms in a single binary easier if we just build all of the dtb files.