On Thu, 16 May 2024 at 13:40, Miquel Raynal miquel.raynal@bootlin.com wrote:
Signed-off-by: Jorge Ramirez-Ortiz jorge@foundries.io
You cannot send your SoB like this. SoB means you are carrying some code which complies with the license, etc.
Either you were part of the original writing and want to be credited for that (you can be the author and first SoB, or suggest Tim to use Co-developed-by). Or you reviewed the change (Reviewed-by), you tested the change (Tested-by), or you are maintainer/responsible for some part that is touched and you agree with the change (Acked-by).
right, however there is some lenience in the process: some projects accept the signed off, some others add the acked or reviewed and so on...
but I agree with you and I certainly do not need/want/expect to be credited for this work. it is all good on my end :)
Thanks, Miquèl
btw you could have simply ignored my note btw : notice the "if needed" part in my response. for reference, I noticed my name in CC, checked the change, thought it was a good idea and tried to move it a long - just chose the wrong tag for sure...
And this is likely a good habit :) But now you need to send your Reviewed-by because these tags are usually collected by the tools. If you don't write it properly, there are very little chances it will ever be picked-up.
I'll pick it up manually. Jorge is it a r-b?
Thanks /Ilias
Thanks, Miquèl