Re: [U-Boot] [PATCH 2/2] e1000: fix PCI memory addressing

On Sat, Aug 22, 2009 at 4:12 AM, Wolfgang Denkwd@denx.de wrote:

This patch causes compiler warnings:

Configuring for MVBC_P board... e1000.c: In function 'e1000_transmit': e1000.c:5019: warning: passing argument 1 of 'virt_to_phys' discards qualifiers from pointer target type

That's odd. I had those warnings at one point on my system and fixed them before I submitted the patch.

...

• DEBUGOUT();

• DEBUGFUNC();

...

These changes are unrelated to the change and not even mentioned in the commit message.

I do mention them:

"Also fix some bad usage of the DEBUGOUT macro"

Unless you're talking about the summary. I figured the changes were harmless and just added them as a freebie. It's not worth submitting a different patch for just these.