Re: [U-Boot] Make cmd_get_data_size() a dependency of setexpr

On Wed, Feb 07, 2018 at 03:31:02PM +0800, qlb1234 wrote:

This commit broke the command setexpr.

http://git.denx.de/?p=u-boot.git;a=commit;h=6f62d7c4f7a2242a76e19b09dccca6f6...

setexpr uses cmd_get_data_size(). If none of I2C, ITEST or PCI is chosen, setexpr will fail to be built.

--- include/command.h +++ include/command.h @@ -80,13 +80,14 @@

• void function (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]);

*/

#if defined(CONFIG_CMD_MEMORY) || \ defined(CONFIG_CMD_I2C) || \ defined(CONFIG_CMD_ITEST) || \

• defined(CONFIG_CMD_PCI)

• defined(CONFIG_CMD_PCI) || \
• defined(CONFIG_CMD_SETEXPR)

#define CMD_DATA_SIZE extern int cmd_get_data_size(char* arg, int default_size); #endif

This seems like a reasonable fix and patch, thanks. However, you need to repost this with your real name used as the author and a signed-off-by line, thanks!