Re: [PATCH v4 3/5] sf: Tidy up code to avoid #ifdef

Hi Simon,

On 19/09/21 03:49PM, Simon Glass wrote:

Update this code to use IS_ENABLED() instead.

Signed-off-by: Simon Glass sjg@chromium.org

Reviewed-by: Pratyush Yadav p.yadav@ti.com

Nitpick: Trailers shouldn't have a blank line between them. I see it for this patch and 4/5 as well. It probably doesn't matter, but I wonder if it will trip up some tools that work on commit trailers like git-interpret-trailers. Something you might want to fix in your workflow...