Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

...

board/xes/common/fsl_8572_clk.c | 51 +++ board/xes/common/fsl_85xx_ddr.c | 93 ++++++ board/xes/common/fsl_85xx_pci.c | 287 +++++++++++++++++

Could you take a look at the new PCI code Kumar submitted (which I just applied), and rework the board code to imitate that code (it should be a trivial change, but one that makes things cleaner)

...

•   /* Invalidate flash region */
  

•   for (i = 0; i < 256 * 1024 * 1024; i += 32) {
  

•           asm volatile ("dcbi %0,%1": : "b" (flashbase), "r" (i));
  

•           asm volatile ("icbi %0,%1": : "b" (flashbase), "r" (i));
  

•   }
  

Take a look at the current 8572DS code for doing this. By mapping things correctly, you can use dcbf, and not have to go through the entire memory space of your flash.

Thanks for the comments Andy. I'll make the changes you referenced as well as a tiny bit of aesthetic cleanup to XPEDITE5370.h and resubmit on Monday.

Peter