Re: [U-Boot] [RFC 07/11] mtd/nand Add Sunxi NAND driver

On Sun, 14 Jun 2015 13:42:12 +0200 Boris Brezillon boris.brezillon@free-electrons.com wrote:

On Fri, 5 Jun 2015 13:52:40 +0200 Roy Spliet r.spliet@ultimaker.com wrote:

...

Heavily based on BBrezillon's (downstream) driver. Most noticable differences

• No per-partition ECC settings. Partitions in U-boot are quite different from Linux
• U-boot register definitions, shared with sunxi_nand_spl
• FDT parsing in-line, there's no framework method yet

I'll try to review this driver next week.

BTW, I don't know if you've based you work on Yassin's work, but if that's the case, then you should at least mention it in the license header, and maybe you should consider adding a S-o-B line with his name.