Hello Michal,
Am 27.10.2015 um 16:02 schrieb Michal Simek:
Do not enable both I2C controllers by default. Enable them only when they are selected.
Signed-off-by: Michal Simek michal.simek@xilinx.com
drivers/i2c/zynq_i2c.c | 4 ++++ 1 file changed, 4 insertions(+)
Thanks!
I will accept this patch, but it is a fix for the old style I2C driver. I would prefer a patch, which converts this driver to DM ;-)
What do you mean with "enabled"? The old style i2c driver, does not initialize (call zynq_i2c_init()) the i2c driver, until it is used ... nevertheless, you save some bytes, which is always good.
Reviewed-by: Heiko Schocher hs@denx.de
bye, Heiko
diff --git a/drivers/i2c/zynq_i2c.c b/drivers/i2c/zynq_i2c.c index b3264af4526e..380863bde148 100644 --- a/drivers/i2c/zynq_i2c.c +++ b/drivers/i2c/zynq_i2c.c @@ -297,11 +297,15 @@ static unsigned int zynq_i2c_set_bus_speed(struct i2c_adapter *adap, return 0; }
+#ifdef CONFIG_ZYNQ_I2C0 U_BOOT_I2C_ADAP_COMPLETE(zynq_0, zynq_i2c_init, zynq_i2c_probe, zynq_i2c_read, zynq_i2c_write, zynq_i2c_set_bus_speed, CONFIG_SYS_I2C_ZYNQ_SPEED, CONFIG_SYS_I2C_ZYNQ_SLAVE, 0) +#endif +#ifdef CONFIG_ZYNQ_I2C1 U_BOOT_I2C_ADAP_COMPLETE(zynq_1, zynq_i2c_init, zynq_i2c_probe, zynq_i2c_read, zynq_i2c_write, zynq_i2c_set_bus_speed, CONFIG_SYS_I2C_ZYNQ_SPEED, CONFIG_SYS_I2C_ZYNQ_SLAVE, 1) +#endif