On 07/08/14 16:49, Marek Vasut wrote:
On Thursday, August 07, 2014 at 03:05:28 PM, Nikita Kiryanov wrote:
Currently, CONFIG_SPL_SPI_* #defines are used for controlling SPI boot in SPL. These #defines do not allow the user to select SPI mode for the SPI flash (there's no CONFIG_SPL_SPI_MODE, so the SPI mode is hardcoded in spi_spl_load.c), and duplicate information already provided by CONFIG_SF_DEFAULT_* #defines.
Kill CONFIG_SPL_SPI_*, and use CONFIG_SF_DEFAULT_* instead.
Cc: Jagannadha Sutradharudu Teki jagannadh.teki@gmail.com Cc: Tom Rini trini@ti.com Cc: Sudhakar Rajashekhara sudhakar.raj@ti.com Cc: Lokesh Vutla lokeshvutla@ti.com Cc: Vitaly Andrianov vitalya@ti.com Cc: Lars Poeschel poeschel@lemonage.de Cc: Bo Shen voice.shen@atmel.com Cc: Hannes Petermaier hannes.petermaier@br-automation.com Cc: Michal Simek monstr@monstr.eu Cc: Marek Vasut marex@denx.de Signed-off-by: Nikita Kiryanov nikita@compulab.co.il
Oh, right. This doesn't collide with the Kconfig work, does it ?
It does not. (No "config CONFIG_SPL_SPI_*", nor "config CONFIG_SF_DEFAULT_*" in any Kconfig files)
Otherwise, I see this as OK,
Reviewed-by: Marek Vasut marex@denx.de
Best regards, Marek Vasut