Re: [U-Boot] [PATCH 03/13] spl: Kconfig: Add CONFIG_SPL_TEXT_BASE as Kconfig option

+Masahiro

Hi Andrew,

On 18 August 2016 at 22:12, Lokesh Vutla lokeshvutla@ti.com wrote:

On Thursday 18 August 2016 09:11 PM, Andrew F. Davis wrote:

...

Add a new Kconfig CONFIG_SPL_TEXT_BASE. Add its use to am335x_evm_defconfig, then only conditionally define it in ti_am335x_common.h when it is not already defined, this allows for systems that have not fully converted to the Kconfig based config system to still include this header without redefining this symbol on platforms that have.

Signed-off-by: Andrew F. Davis afd@ti.com

Kconfig | 8 ++++++++ configs/am335x_evm_defconfig | 1 + include/configs/ti_am335x_common.h | 2 ++ 3 files changed, 11 insertions(+)

diff --git a/Kconfig b/Kconfig index cb5af5b..f67e7c8 100644 --- a/Kconfig +++ b/Kconfig @@ -319,6 +319,14 @@ config SYS_TEXT_BASE help TODO: Move CONFIG_SYS_TEXT_BASE for all the architecture

+config SPL_TEXT_BASE

• hex "Text Base"
  

• depends on SPL
  

• help
  

•   When SPL is enabled the image is linked with this as the
  

•   starting address in memeory for which the SPL will be loaded.
  

•   TODO: Move CONFIG_SPL_TEXT_BASE for all the architecture
  

Nice to see this in a common place. There are some boards which has already defined this as Kconfig option. You need to remove the current definition or else build might break.

Yes it is great to see this!

You can use the moveconfig.py tool to help with finishing the migration.

Regards, Simon