On Tue, 2 Jun 2009 01:08:53 +0900 "Kim, Heung Jun" riverful@gmail.com wrote:
Dear Kim Philips,
Thanks to review & help.
- while making backreferences by pointing to messages in the list
archive is cool, they don't stand the test of time - the URL may one day cease to exist. So it is better to either reference a commitish in the repository itself, or simply restate/copy the original data.
But, I don't understand idea 3 well. Let me know more detailed? :-) I don't understand the word "commitish" & the meaning of "original data". And, I think that you tell me to simplify the comments. Is it right or something like?
basically, I'm saying that backreferences should only be git commit ID's ('commitish' in git terminology). See e.g., "Commit 574b319512 introduced" and "A later fix in commit 8ec6e332ea" below:
commit af75a45d23b72a59ac5cc0427696c7f634fdc94b Author: Wolfgang Denk wd@denx.de Date: Fri May 15 09:27:58 2009 +0200
IDE: bail out of dev_print() for unknown device types
Commit 574b319512 introduced a subtle bug by mixing a list of tests for "dev_desc->type" and "dev_desc->if_type" into one switch(), which then mostly did not work because "dev_desc->type" cannot take any "IF_*" type values. A later fix in commit 8ec6e332ea changed the switch() into testing "dev_desc->if_type", but at this point the initial test for unknown device types was completely lost, which resulted in output like that for IDE ports without device attached:
Device 1: Model: Firm: Ser#: Type: # 1F # Capacity: not available
This patch re-introduces the missing test for unknown device types.
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Stefan Roese sr@denx.de Cc: Detlev Zundel dzu@denx.de Tested-by: Stefan Roese sr@denx.de
...and if your commit message wants to reference something that is _not_ already in the repository, e.g., in your case I think you have this compiler error:
cpu.c:99: warning: function declaration isn't a prototype cpu.c: In function 'l2cache_enable': cpu.c:104: warning: implicit declaration of function 'get_cpu_rev' cpu.c:104: error: 'CPU_3XX_ES20' undeclared (first use in this function) cpu.c:104: error: (Each undeclared identifier is reported only once cpu.c:104: error: for each function it appears in.) cpu.c: At top level: cpu.c:129: warning: function declaration isn't a prototype cpu.c: In function 'l2cache_disable': cpu.c:134: error: 'CPU_3XX_ES20' undeclared (first use in this function) make[1]: *** [cpu.o] Error 1
...so please copy it into the commit message, so that it lives as long as the life of the project (as opposed to the life of the maillist archive server URL).
Kim