-----Original Message----- From: Lei Wen [mailto:adrian.wenl@gmail.com] Sent: Thursday, January 06, 2011 8:59 AM To: Prafulla Wadaskar Cc: Lei Wen; u-boot@lists.denx.de; Yu Tang; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-BOOT] [PATCH 2/6] mv: seperate kirkwood and mmp from common setting
...snip...
put into the common code... #ifndef CONFIG_ARMADA100 /* will be removed latter */-#define CONFIG_CMD_EXT2 #define CONFIG_CMD_JFFS2 #define CONFIG_CMD_FAT #define CONFIG_CMD_UBI #define CONFIG_CMD_UBIFS #define CONFIG_RBTREE #define CONFIG_MTD_DEVICE /* needed for mtdparts
commands
*/ #define CONFIG_MTD_PARTITIONS #define CONFIG_CMD_MTDPARTS #define CONFIG_LZO #endif
Well, we can.. only replace #ifndef CONFIG_ARMADA100 with #ifdef CONFIG_SYS_MVFS and
define this macro in arch-kirkwood/config.h, this way in future after enabling ide, nand, spi driver support just defining the same macro in armada100/config.h will enable the file system support for armada100 platforms.
I think not all platform under marvell would need to enable all those configure... What if it only want to enable one setting from this big group, like it only want the CONFIG_CMD_FAT, then you need to it set the CONFIG_SYS_MVFS with other unnessary setting enabled...
Please follow the strategy used to include <config_cmd_default.h> in board config file, further followed by #undef for not needed definitions.
Regards.. Prafulla ..