On 21/11/14 10:26, Suriyan Ramasami wrote:
The USB host code was missing gpio_request() calls before using the gpio functions, causing errors to be printed out.
As a side note calls to max77686_set_buck_mode(OPMODE_OFF/OPMODE_ON) have been removed, as they did not have any effect. This is as per Przemyslaw: I looked into the documentation and there is a "ENB8" pin in PMIC package. This pin allows steering BUCK8 ON/OFF by the vhardware. If ENB8 is set to low then you can do on/off. If high, then you cannot change its state by I2C write, which seems to be the case with the Odroids.
Signed-off-by: Suriyan Ramasami suriyan.r@gmail.com Acked-by: Przemyslaw Marczak p.marczak@samsung.com
Changes in v2:
- Add comment why max77686_set_buck_mode() has been removed
Series-changes: 1
- Added gpio_request() call in board_gpio_init()
board/samsung/odroid/odroid.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
applied to u-boot-samsung.
Thanks, Minkyu Kang.