Re: [U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox

Hi Simon,

Am 23.07.2016 um 04:31 schrieb Simon Glass:

On 18 July 2016 at 06:13, Heiko Stübner heiko@sntech.de wrote:

...

Am Montag, 18. Juli 2016, 03:06:07 schrieb Andreas Färber:

...

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 86b77f8..597f043 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -3,6 +3,10 @@ if ARCH_ROCKCHIP config ROCKCHIP_RK3288 bool "Support Rockchip RK3288" select CPU_V7

• select SUPPORT_SPL
  

• select SPL
  

• select SPL_DM
  

• select SPL_SYS_MALLOC_SIMPLE
  help
    The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17
    including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two
  

@@ -13,12 +17,21 @@ config ROCKCHIP_RK3288 config ROCKCHIP_RK3036 bool "Support Rockchip RK3036" select CPU_V7

• select SUPPORT_SPL
  

• select SPL
  

• select SPL_DM
  

• select SPL_SYS_MALLOC_SIMPLE
  help
    The Rockchip RK3036 is a ARM-based SoC with a dual-core Cortex-A7
    including NEON and GPU, Mali-400 graphics, several DDR3 options
    and video codec support. Peripherals include Gigabit Ethernet,
    USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
  

looks like both you and Kever need that separation of the SPL symbols (me as well for the rk3188 for the time being), so it might make sense to split that out into a separate patch, all could use.

I guess it might also make it easier for Simon to find an order to apply the patches?

Yes. Andreas, can you please resent your patches against u-boot-rockchip/master?

I had done that and thereby ran into the mismerges I pointed out. ;) Didn't send that blown-up version out since you suggested an rk3399 resend, which came once I was unavailable over the extended weekend...

Also it needs a MAINTAINERS file I think.

True.

Regards, Andreas