Hi Marek,
On 08/11/2011 12:38 PM, Marek Vasut wrote:
On Thursday, August 11, 2011 04:19:45 AM Hong Xu wrote:
The default cache operations defined in arch/arm/lib/cache.c do not perform any real cache operation, and instead a WARNING will be emitted.
Signed-off-by: Hong Xuhong.xu@atmel.com Tested-by: Elen Songelen.song@atmel.com CC: Albert Aribaudalbert.u.boot@aribaud.net CC: Aneesh Vaneesh@ti.com CC: Marek Vasutmarek.vasut@gmail.com CC: Reinhard Meyeru-boot@emk-elektronik.de CC: Heiko Schocherhs@denx.de
arch/arm/lib/cache.c | 55 ++++++++++++++++++++++++++++--------------------- 1 files changed, 31 insertions(+), 24 deletions(-)
diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c index 92b61a2..6af05ec 100644 --- a/arch/arm/lib/cache.c +++ b/arch/arm/lib/cache.c @@ -20,36 +20,43 @@
- Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- MA 02111-1307 USA
*/ +#include<linux/compiler.h> +#include<common.h>
-/* for now: just dummy functions to satisfy the linker */ +#define EMIT_WARNING printf("WARNING: %s - CPU cache operation is not " \ +"implemented!\n", __func__)
Maybe use debug() ? Or make the emission of warning conditional, somehow I have the feeling this will make some people unhappy.
Just my feelings: It's noisy but it'll give strong message to the user even if the DEBUG is not opened :-)
BR, Eric
Otherwise looks nice and clean.
-#include<common.h> +/*
[...]