Re: [PATCH 1/1] smbios: empty strings in smbios_add_string()

5 Jun 2020


      On Mon, 1 Jun 2020 at 07:44, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
...
smbios_add_string() cannot deal with empty strings. This leads to incorrect
property values and invalid tables. E.g. for the pine64-lts_defconfig
CONFIG_SMBIOS_MANUFACTURER="". Linux command dmidecode shows:
Table 1:
    Manufacturer: sunxi
    Product Name: sunxi
Table 3:
    Invalid entry length (2). DMI table is broken! Stop.
Replace empty strings by "Unknown".
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
lib/smbios.c | 2 ++
 1 file changed, 2 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org