Hi,
On 11/17/2014 07:54 PM, Ian Campbell wrote:
On Sun, 2014-11-16 at 17:16 +0100, Hans de Goede wrote:
+config DRAM_ZQ
- int "sun6i dram zq value" if EXPERT
- default 123
== 0x7b, which differs from the previous default of 0x78 (not by much, but still)
Right, this is deliberate as I've gotten access to more boards, 123 seems a better default (this is also what most A10 / A13 / A20 boards use).
diff --git a/configs/Colombus_defconfig b/configs/Colombus_defconfig index bef568d..5e245a3 100644 --- a/configs/Colombus_defconfig +++ b/configs/Colombus_defconfig @@ -4,3 +4,5 @@ CONFIG_FDTFILE="sun6i-a31-colombus.dtb" +S:CONFIG_ARCH_SUNXI=y +S:CONFIG_MACH_SUN6I=y +S:CONFIG_TARGET_COLOMBUS=y ++S:CONFIG_DRAM_CLK=288 ++S:CONFIG_DRAM_ZQ=379
Do these actually take affect if CONFIG_EXPERT=n?
Ugh, I just checked, and no they don't.
Perhaps CONFIG_TARGET_COLOMBUS should select DRAM_CLK == 288 and DRAM_CLK should be a hidden option?
I would prefer to keep these inside the defconfig's so that for adding a new board only a defconfig needs to be added.
Currently the only CONFIG_TARGET_BOARD we actually use in u-boot is the bananapi gmac tx clk delay tweak, and I would actually like to keep things that way. Actually thinking more about this, I think that that should be turned into a GMAC specific Kconfig option and all the CONFIG_TARGET_BOARD stuff should be dropped, as it is just a drag causing extra maintenance going forward.
So is there a way to not show a choice to the user unless EXPERT mode is set, and still override it from Kconfig ?
If that is not (easily) possible, then I guess we will just need to not make these "if EXPERT".
Regards,
Hans