Re: [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole

On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote:

--- a/drivers/net/tsec.c +++ b/drivers/net/tsec.c

• if (strcmp(getenv("stdout"), "nc"))

i really don't like special casing devices like this

• serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,

• 	(phydev->duplex) ? "full" : "half",
  

• 	(phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
  

• serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
  

• 		(phydev->duplex) ? "full" : "half",
  

• 		(phydev->port == PORT_FIBRE) ? ", fiber mode"
  

• 		: "");
  

why not just delete this line completely ? -mike