Hi,
I have another thing that might be added in cfi_flash.c.
Please correct me if I am wrong, but the monitor protection must not be applied (at least not in this way) when U-Boot is running from RAM. The original test is probably not a problem on the architectures where the flash address range is above (SD)RAM, but for the architectures where flash has to start at 0x0 (e.g. Coldfire), I would ask for the patch below to be applied:
--- drivers/cfi_flash.c.sicher 2007-07-04 08:35:43.000000000 +0000 +++ drivers/cfi_flash.c 2007-07-04 08:35:37.000000000 +0000 @@ -397,7 +397,7 @@ }
/* Monitor protection ON by default */ -#if (CFG_MONITOR_BASE >= CFG_FLASH_BASE) +#if !defined(CONFIG_MONITOR_IS_IN_RAM) && (CFG_MONITOR_BASE >= CFG_FLASH_BASE) flash_protect (FLAG_PROTECT_SET, CFG_MONITOR_BASE, CFG_MONITOR_BASE + monitor_flash_len - 1,
Best regards, Wolfgang