Hi Igor,
On Tue, May 15, 2018 at 07:58:51PM +0300, Igor Opaniuk wrote:
Hi Eugeniu,
You're totally right regarding avb internal headers, they all should remain in lib/libavb. v2 patchset (planning to send it by the end of this week) will include these changes you're talking about (+ will include libavb updates from [1]).
Good to hear that!
I've taken a quick look at patches from [2], and noticed a few issues (IMHO):
- It includes custom implementation of RPMB operations, although
generic RPMB functionality already exists in the U-boot mainline (check drivers/mmc/rpmb.c) 2) It introduces a brand-new "boota" command for booting Android, although existing bootm does already support Android boot image parsing and booting. 3) It doesn't have any dm-verify enforcement policies in case if the bootloader is in the "locked" state (at least, I didn't manage to grep it) 4) There are a bunch of platform-specific code introduced to fastboot driver, and it's used as a base for working with GPT in avb ops (sounds strange, but this is what I see here), although mainline U-boot does have API for this purposes.
Thanks for the detailed reply. I am looking forward for a cleaner and better partitioned porting of libavb/libavb_ab to the main tree. Your effort is very appreciated!
Regards, Igor
[1] https://android.googlesource.com/platform/external/avb/+/master [2] http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/tree/lib/avb/fsl?h=i...
Best regards, Eugeniu.