On 16/05/24 11:34:14, Miquel Raynal wrote:
Hi Jorge,
...
- board with no reset gpio
u-boot=> tpm init && tpm info tpm@1 v2.0: VendorID 0x1114, DeviceID 0x3205, RevisionID 0x01 [open]
- board with a reset gpio
u-boot=> tpm init && tpm info tpm@1: TPM gpio reset should not be used on secure production devices tpm@1 v2.0: VendorID 0x1114, DeviceID 0x3205, RevisionID 0x01 [open]
[1] https://trustedcomputinggroup.org/wp-content/uploads/TCG_PCClientTPMInterfac...
Signed-off-by: Tim Harvey tharvey@gateworks.com
Looks way cleaner, thanks.
Reviewed-by: Miquel Raynal miquel.raynal@bootlin.com
Miquèl
nice. if needed
Signed-off-by: Jorge Ramirez-Ortiz jorge@foundries.io
You cannot send your SoB like this. SoB means you are carrying some code which complies with the license, etc.
Either you were part of the original writing and want to be credited for that (you can be the author and first SoB, or suggest Tim to use Co-developed-by). Or you reviewed the change (Reviewed-by), you tested the change (Tested-by), or you are maintainer/responsible for some part that is touched and you agree with the change (Acked-by).
right, however there is some lenience in the process: some projects accept the signed off, some others add the acked or reviewed and so on...
but I agree with you and I certainly do not need/want/expect to be credited for this work. it is all good on my end :)
Thanks, Miquèl
btw you could have simply ignored my note btw : notice the "if needed" part in my response. for reference, I noticed my name in CC, checked the change, thought it was a good idea and tried to move it a long - just chose the wrong tag for sure...