Re: [U-Boot] [PATCH 2/2] arm: mvebu: armada-xp/37x/38x: Enable PCIe DT node

Hi Stefan,

On Fri, Jan 18, 2019 at 2:35 AM Stefan Roese sr@denx.de wrote:

This patch enables the DT PCIe nodes for the Armada XP/37x/38x boards. This is needed for the new DM_PCI support in the MVEBU PCIe driver.

Signed-off-by: Stefan Roese sr@denx.de Cc: Dirk Eibach dirk.eibach@gdsys.cc Cc: Mario Six mario.six@gdsys.cc Cc: Chris Packham chris.packham@alliedtelesis.co.nz Cc: Phil Sutter phil@nwl.cc Cc: Marek Behún marek.behun@nic.cz Cc: VlaoMao vlaomao@gmail.com

---

arch/arm/dts/armada-375.dtsi | 2 +- arch/arm/dts/armada-380.dtsi | 2 +- arch/arm/dts/armada-385.dtsi | 2 +- arch/arm/dts/armada-xp-mv78230.dtsi | 2 +- arch/arm/dts/armada-xp-mv78260.dtsi | 2 +- arch/arm/dts/armada-xp-mv78460.dtsi | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)

I think this should be at the board level instead of the SoC. There are boards that don't use the pcie controller even though it's in the SoC. Another good reason is that this deviates from the dtsi files in Linux

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch...

diff --git a/arch/arm/dts/armada-375.dtsi b/arch/arm/dts/armada-375.dtsi index 249c41c757..7b2723cdf2 100644 --- a/arch/arm/dts/armada-375.dtsi +++ b/arch/arm/dts/armada-375.dtsi @@ -584,7 +584,7 @@

            pcie-controller {
                    compatible = "marvell,armada-370-pcie";

•                   status = "disabled";
  

•                   status = "okay";
                    device_type = "pci";
  
                    #address-cells = <3>;
  

diff --git a/arch/arm/dts/armada-380.dtsi b/arch/arm/dts/armada-380.dtsi index 5102d19cc8..95c8a1bae0 100644 --- a/arch/arm/dts/armada-380.dtsi +++ b/arch/arm/dts/armada-380.dtsi @@ -73,7 +73,7 @@

            pcie-controller {
                    compatible = "marvell,armada-370-pcie";

•                   status = "disabled";
  

•                   status = "okay";
                    device_type = "pci";
  
                    #address-cells = <3>;
  

diff --git a/arch/arm/dts/armada-385.dtsi b/arch/arm/dts/armada-385.dtsi index 8e67d2c083..d1d277e165 100644 --- a/arch/arm/dts/armada-385.dtsi +++ b/arch/arm/dts/armada-385.dtsi @@ -78,7 +78,7 @@

            pcie-controller {
                    compatible = "marvell,armada-370-pcie";

•                   status = "disabled";
  

•                   status = "enabled";
                    device_type = "pci";
  
                    #address-cells = <3>;
  

diff --git a/arch/arm/dts/armada-xp-mv78230.dtsi b/arch/arm/dts/armada-xp-mv78230.dtsi index 6e6d0f04bf..d750ac1f6f 100644 --- a/arch/arm/dts/armada-xp-mv78230.dtsi +++ b/arch/arm/dts/armada-xp-mv78230.dtsi @@ -88,7 +88,7 @@ */ pcie-controller { compatible = "marvell,armada-xp-pcie";

•                   status = "disabled";
  

•                   status = "okay";
                    device_type = "pci";
  
                    #address-cells = <3>;
  

diff --git a/arch/arm/dts/armada-xp-mv78260.dtsi b/arch/arm/dts/armada-xp-mv78260.dtsi index c5fdc99f0d..50d3716b96 100644 --- a/arch/arm/dts/armada-xp-mv78260.dtsi +++ b/arch/arm/dts/armada-xp-mv78260.dtsi @@ -89,7 +89,7 @@ */ pcie-controller { compatible = "marvell,armada-xp-pcie";

•                   status = "disabled";
  

•                   status = "okay";
                    device_type = "pci";
  
                    #address-cells = <3>;
  

diff --git a/arch/arm/dts/armada-xp-mv78460.dtsi b/arch/arm/dts/armada-xp-mv78460.dtsi index 0e24f1a385..5921f41264 100644 --- a/arch/arm/dts/armada-xp-mv78460.dtsi +++ b/arch/arm/dts/armada-xp-mv78460.dtsi @@ -106,7 +106,7 @@ */ pcie-controller { compatible = "marvell,armada-xp-pcie";

•                   status = "disabled";
  

•                   status = "okay";
                    device_type = "pci";
  
                    #address-cells = <3>;
  

-- 2.20.1

---

U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot