Re: [U-Boot] universal_c210: fix compiler error and compiler warning

Dear Lukasz Majewski,

In message 20121210103224.372c572e@amdc308.digital.local you wrote:

...

This is unrelated to your patch - but what if pmic_get() returns NULL?

pmic_probe() will crashif you pass it a NULL pointer...

The PMIC 2.0 uses malloc to allocate pmic structure.

...and malloc() can fail.

The fix, which has been proposed would work for old pmic.

In the new one PMIC 2.0, we require to test return pointer from pmic_get() (similar to all malloc allocations):

struct pmic *p = pmic_get("MAX8998_PMIC"); if (!p) return -ENODEV;

So this code here needs fixing. This is what I wanted to point out.

Best regards,

Wolfgang Denk