On 13 Sep 2017, at 06:25, Simon Glass sjg@chromium.org wrote:
On 11 September 2017 at 05:59, Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:
To support the new "same-as-spl" specifier in the boot-order on the RK3399, this implements the chip-specific mapping from the information obtainable from the BROM to a OF path name.
Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
arch/arm/mach-rockchip/rk3399-board-spl.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
This feels a bit klugey. Does SPL not have access to the same DT? If so then (at some point when we add support) perhaps it could pass its name through?
This is for the SPL stage (I may have not made this sufficiently clear in the documentation): ‘same-as-spl’ is really intended to direct the SPL stage to search for the full U-Boot stage in the same device the SPL was loaded from.
We use this feature for our boot-override slider (the BIOS_DISABLE) signal to allow us to inject the “same device the SPL was loaded from” early on in the search-order for the FIT image containing the ATF, FDT and full U-Boot.
Injecting this info (and also the expanded name of the entry in the search-order that was finally used) into the DT later on would be a nice future enhancement that would allow later stages (and the full OS) to know about where things were booted from.
Regard, Philipp.