Re: [U-Boot] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

In message 20080809091101.GC18040@game.jcrosoft.org you wrote:

...

• /*
  

•  * for 10 ms clock period @ PCLK with 4 bit divider = 1/2 and
  

•  * prescaler = 16. Should be 10390 @33.25MHz and 15625 @ 50 MHz
  

•  */
  

• timer_load_val = get_PCLK() / PRESCALER * (100 / 4); /* 100s */
  

• /*printf("Calculated %lu timer_load_val\n", timer_load_val);*/
  

please remove if not need

Or even better convert it into a debug() call so it can be enabled again for debugging purposes.

...

• timers->TCFG1 = (timers->TCFG1 & ~0xf0000) | 0x20000;
  

• }

please add some empty line to be more readable

No. One empty line os enough here.

...

+#define NFADDR (ELFIN_NAND_BASE+NFADDR_OFFSET)

             ^^^^^^^^^^^

please remove whitesapce

Not remove, but use TABs vor vertical alignment.

Best regards,

Wolfgang Denk