hi Wolfgang,
On Fri, Oct 22, 2010 at 2:22 PM, Sughosh Ganu urwithsughosh@gmail.comwrote:
hi Wolfgang,
On Fri Oct 22, 2010 at 10:05:43AM +0200, Wolfgang Denk wrote:
#if defined(CONFIG_ARM) && !defined(CONFIG_SYS_ARM_WITHOUT_RELOC)
-void board_init_f (ulong bootflag) +void __board_init_f (ulong bootflag) { relocate_code (CONFIG_SYS_TEXT_BASE - TOTAL_MALLOC_LEN,
NULL,
CONFIG_SYS_TEXT_BASE);} +void board_init_f (ulong bootflag)__attribute__((weak,
alias("__board_init_f")));
#endif
This is a global change that affects all NAND booting boards. This must be submitted spearately, and you must explain in detail why you think you need that. Also please mention on which systems this
change
has been tested.
For hawkboard, we need to do some board specific initialisation which can be included in board_init_f. The freescale boards which
Can you probably do it in any of the other, board dependent init functions?
Not sure on this one. The only board specific function that gets called in the nand spl stage is board_init_f.
I was checking the usage of board_init_f in the nand_spl/nand_boot.c file, and currently only the smdk6400 board uses it. Can we then remove this function definition from the nand_boot.c file and put it in the respective board file, like the freescale boards. I think this is a cleaner way of implementing this. Please le me know, and i will base my changes accordingly. Thanks.
-sughosh