Hi Albert,
On 02/10/2014 10:36 AM, Albert ARIBAUD wrote:
Hi Michal,
On Mon, 10 Feb 2014 10:30:37 +0100, Michal Simek monstr@monstr.eu wrote:
Hi Albert,
On 02/10/2014 10:11 AM, Albert ARIBAUD wrote:
Hi Michal,
On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek michal.simek@xilinx.com wrote:
The reason is enabling tftpput command where tftp shorcut stops to work for tftpboot.
Do you think you could extend this patch to all config files where the 'tftp' shortcut exists? This would prevent future issues on targets other than Zynq and hopefully it is only a matter of grepping / sed'ing through include/configs/*.h.
Based on my experience it is better to use full commands in variables but on the other hand I have met with the case when adding these 4 chars caused that max variable size has been exceed with error.
It means for short variables I can't see any problem with it and definitely will be better to use full command names instead of shortcut.
Extending to "short variables" only is fine with me -- I'm not asking you to re-engineer config header files, only to perform a cheap and useful search-and-replace.
Let's wait for others what they think and separate this from this patch because there is one more patch depends on this which you can see in my pull request. I think we shouldn't limit this just to include/configs/*.h but also to all READMEs and comments.
Thanks, Michal