Hi Wolfgang,
On Tue, Mar 6, 2012 at 7:26 AM, Wolfgang Denk wd@denx.de wrote:
Dear Simon Glass,
In message CAPnjgZ1BMMrN-+bHFr9GcH-5wF4WSz_7Qa53C_cHPLEbL2ycqA@mail.gmail.com you wrote: ...
The environment variables preboot, bootcmd and menucmd can hold a command to execute. This change permits these variables to have newlines so that they work the same as the 'source' command.
...
The first patch is just a clean-up and should not change any behaviour. This second patch changes the behaviour of the named env variables.
So which commit introduced the breakage, then?
Which breakage are you referring to? The intent of these two patches is to add a new feature (proposed by Michael Walle michael@walle.cc who also provided a patch) on top of the command refactor series.
Sorry, there is some confusion here but I'm not sure what it is.
Guess I'm confused.
I don't understand in which way the variables listed here (preboot, bootcmd and menucmd) are special - actually all variables can hold commands, that then can be executed using the "run" command.
If newline is a valid command separator (and I think it is), this should work for _all_ variable.
OK I see. It is my commit message that is confusing, sorry. I didn't mean that only those env variables can hold a command, just that this patch affects the code which makes those environment variables work.
I will update the commit message and resend this patch.
Regards, Simon
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Backed up the system lately?