Re: [U-Boot] [PATCH 8/8] mcx: support for HTKW mcx board

Hi Ilya,

On 10/13/11 23:11, Ilya Yanok wrote:

This patch adds support for the HTKW mcx AM3517-based board. Serial, Ethernet, NAND and MMC are supported.

Requires updated mach-types file.

Signed-off-by: Ilya Yanok yanok@emcraft.com

[...]

diff --git a/board/htkw/mcx/mcx.c b/board/htkw/mcx/mcx.c new file mode 100644 index 0000000..00bd564 --- /dev/null +++ b/board/htkw/mcx/mcx.c

[...]

+#define AM3517_IP_SW_RESET 0x48002598 +#define CPGMACSS_SW_RST (1 << 1)

[...]

+int misc_init_r(void) +{ +#if defined(CONFIG_DRIVER_TI_EMAC)

• u32 reset;

+#endif

• dieid_num_r();

+#if defined(CONFIG_DRIVER_TI_EMAC)

• /* ensure that the module is out of reset */
• reset = readl(AM3517_IP_SW_RESET);
• reset &= ~CPGMACSS_SW_RST;
• writel(reset, AM3517_IP_SW_RESET);

+#endif

• return 0;

+}

I don't really insist, but couldn't the EMAC reset be handled in the cpu_eth_init() function, instead of each board does the reset itself?

[...]