Tom said the following on 06/20/2009 01:22 PM:
Menon, Nishanth wrote:
-----Original Message----- From: Tom Rix [mailto:Tom.Rix@windriver.com] Sent: Thursday, June 18, 2009 11:14 PM To: u-boot@lists.denx.de; Menon, Nishanth; dirk.behme@googlemail.com Cc: Tom Rix Subject: [PATCH 1/3] OMAP3 I2C Fix the sampling clock.
Acked-by: Nishanth Menonnm@ti.com
There is one comment below though..
Signed-off-by: Tom Rix Tom.Rix@windriver.com
drivers/i2c/omap24xx_i2c.c | 34 +++++++++++++++++++----- include/asm-arm/arch-omap3/i2c.h | 54 +++++++++++++++++++++++++++++++++----- 2 files changed, 74 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c index 6784603..ecdf1f2 100644 --- a/drivers/i2c/omap24xx_i2c.c +++ b/drivers/i2c/omap24xx_i2c.c @@ -31,7 +31,29 @@ static void flush_fifo(void);
void i2c_init (int speed, int slaveadd) {
- u16 scl;
- int psc, scll, sclh;
- /* Only handle standard and fast speeds */
- if ((speed != OMAP_I2C_STANDARD) &&
(speed != OMAP_I2C_FAST_MODE)) {printf("Error : I2C unsupported speed %d\n", speed);return;- }
We may want to bring the HSI2C support back in though
How about I do this in a later patch? The configs I looked at only used the much slower standard speed.
Sounds good as long as it is in TODO somewhere.. kinda sad if we talk 400khz to TWL5030 which could go upto 2.4mhz or so.. Regards, Nishanth Menon