Re: [U-Boot] [PATCH resend 1/3] tegra20: complete periph_id enum

Lucas,

On Wed, Sep 26, 2012 at 9:19 AM, Tom Warren TWarren@nvidia.com wrote:

Lucas,

...

-----Original Message----- From: Lucas Stach [mailto:dev@lynxeye.de] Sent: Tuesday, September 25, 2012 11:21 PM To: Tom Warren Cc: u-boot@lists.denx.de Subject: [PATCH resend 1/3] tegra20: complete periph_id enum

Please see http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions ("Sending updated patch versions"). It's hard to track these patches with disparate subject lines - they should all be grouped as '[PATCH n/3 v3] tegra20: ...', etc. Also, your change logs ('v3 - fix checkpatch complaints', etc.) should be below the '---' line so they don't get included in the commit message.

I'll apply these this time, since they're small, but please follow the rules on the wiki future updated patches. It makes it much easier for me to track these in Patchwork.

Thanks,

Tom

...

Most Tegra boards output the ULPI reference clock on pad DEV2.

Complete the periph_id enum so that we are able to enable this clock output circuit.

Signed-off-by: Lucas Stach dev@lynxeye.de Acked-by: Stephen Warren swarren@wwwdotorg.org Acked-by: Simon Glass sjg@chromium.org

---

arch/arm/cpu/tegra20-common/clock.c | 1 + arch/arm/include/asm/arch-tegra20/clock.h | 6 ++++++ 2 Dateien geändert, 7 Zeilen hinzugefügt(+)

diff --git a/arch/arm/cpu/tegra20-common/clock.c b/arch/arm/cpu/tegra20- common/clock.c index 2403874..d9bb851 100644 --- a/arch/arm/cpu/tegra20-common/clock.c +++ b/arch/arm/cpu/tegra20-common/clock.c @@ -502,6 +502,7 @@ static int clock_periph_id_isvalid(enum periph_id id) case PERIPH_ID_RESERVED81: case PERIPH_ID_RESERVED82: case PERIPH_ID_RESERVED83:

•         case PERIPH_ID_RESERVED91:
                  printf("Peripheral id %d is reserved\n", id);
                  break;
          default:
  

diff --git a/arch/arm/include/asm/arch-tegra20/clock.h b/arch/arm/include/asm/arch-tegra20/clock.h index ff83bbf..20db9e6 100644 --- a/arch/arm/include/asm/arch-tegra20/clock.h +++ b/arch/arm/include/asm/arch-tegra20/clock.h @@ -175,6 +175,12 @@ enum periph_id {

  /* 88 */
  PERIPH_ID_CRAM2,

• PERIPH_ID_SYNC_CLK_DOUBLER,
  

• PERIPH_ID_CLK_M_DOUBLER,
  

• PERIPH_ID_RESERVED91,
  

• PERIPH_ID_SUS_OUT,
  

• PERIPH_ID_DEV2_OUT,
  

• PERIPH_ID_DEV1_OUT,
  
  PERIPH_ID_COUNT,
  PERIPH_ID_NONE = -1,
  

-- 1.7.11.4

-- nvpublic

This series (3 patches) applied to u-boot-tegra/next and pushed to denx.de.

Thanks,

Tom