On 11/07/2011 11:05 PM, Wolfgang Denk wrote:
Dear Gerlando Falauto,
In message4EB84859.6000906@keymile.com you wrote:
-int _do_env_set (int flag, int argc, char * const argv[]) +int env_check_apply(const char *name, const char *oldval,
const char *newval, int flag)Please use only TAB for indentation. Please fix globally.
From fs/ubibfs/ubifs.h:
Never ever use examples from other code to argument your's was right - the example you chose might be wrong as well.
The purpose was not to argument mine was right.
Could you please provide some examples as to what would be the correct coding style for function declarations and/or function calls that spawn on multiple lines? I could not find anything on the topic.
http://www.denx.de/wiki/U-Boot/CodingStyle:
Use TAB characters for indentation and vertical alignment, not spaces
That's exactly what you told me in your reply, and doesn't answer my question. The only way I could think of to achieve vertical alignment in a complex if statement without recurring to spaces is by adding extra tabs between parentheses, with an enormous waste of space. Your answer might as well be: "forget about alignment altogether, nobody wants that, just indent it somehow".
- if (himport_ex(&env_htab, (char *)default_environment,
sizeof(default_environment), '\0', 0,0, NULL, apply_function) == 0) {What should be the right indentation?
In any case it makse no sense to have the 2nd and 3rd line indented differently, right?
That's absolutely right. Once again, though, you did not help me understand what The Right Thing (tm) is. I also made a shy attempt, but you're not telling me whether it's good or not. It's hard to follow some guidelines when they're not clearly stated.
Thank you, Gerlando Falauto