Hi Christian,
On Tue, 21 Oct 2014 13:43:36 +0200 Christian Gmeiner christian.gmeiner@gmail.com wrote:
Hi all.
Finally I got basic board support for OT1200 into upstream, but the last released version fails to detect SPI flash (read only ff's).
The good one is commit 39d0973300b83c08f3f5047245ebf1de883b31f2 and the bad one is c43fd23cf619856b0763a64a6a3bcf3663058c49
$ git log 39d097330..c43fd23c drivers/spi/mxc_spi.c commit 155fa9af95ac5be857a7327e7a968a296e60d4c8 Author: Nikita Kiryanov nikita@compulab.co.il Date: Wed Aug 20 15:08:50 2014 +0300
spi: mxc: fix sf probe when using mxc_spi
MXC SPI driver has a feature whereas a GPIO line can be used to force CS high across multiple transactions. This is set up by embedding the GPIO information in the CS value:
cs = (cs | gpio << 8)
This merge of cs and gpio data into one value breaks the sf probe command: if the use of gpio is required, invoking "sf probe <cs>" will not work, because the CS argument doesn't have the GPIO information in it. Instead, the user must use "sf probe <cs | gpio << 8>". For example, if bank 2 gpio 30 is used to force cs high on cs 0, bus 0, then instead of typing "sf probe 0" the user now must type "sf probe 15872".
This is inconsistent with the description of the sf probe command, and forces the user to be aware of implementaiton details.
Fix this by introducing a new board function: board_spi_cs_gpio(), which will accept a naked CS value, and provide the driver with the relevant GPIO, if one is necessary.
Cc: Eric Nelson eric.nelson@boundarydevices.com Cc: Eric Benard eric@eukrea.com Cc: Fabio Estevam fabio.estevam@freescale.com Cc: Tim Harvey tharvey@gateworks.com Cc: Stefano Babic sbabic@denx.de Cc: Tom Rini trini@ti.com Cc: Marek Vasut marex@denx.de Reviewed-by: Marek Vasut marex@denx.de Signed-off-by: Nikita Kiryanov nikita@compulab.co.il Reviewed-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com
Does it work if you revert 155fa9af ?
Thanks,
Anatolij