Stephen,
On Mon, Dec 3, 2012 at 5:34 PM, Stephen Warren swarren@wwwdotorg.org wrote:
On 12/03/2012 04:45 PM, Tom Warren wrote:
This provides SPL support for T30 boards - AVP early init, plus CPU (A9) init/jump to main U-Boot.
Some changes were made to Tegra20 cpu.c to move common routines into tegra-common/cpu.c and reduce code duplication.
arch/arm/cpu/arm720t/tegra-common/cpu.c | 342 ++++++++++++++++++++++++++++ arch/arm/cpu/arm720t/tegra20/cpu.c | 216 ++----------------
Just a minor note here; this patch both moves a bunch of code from cpu.c to the new cpu.c, and adds Tegra30 support. It would have been a little easier to review if the code move were a separate patch (with git format-patch -C) so that it was obvious what code in the new cpu.c was changes due to Tegra30 and what was just copied.
Perhaps. But I didn't want to delay the T30 patches any longer while waiting for a 'commonize cpu.c' patchset for T20 to trickle through.
I had also tried creating this particular patch with 'git-format -M -C', and it created confusing 'copy foo->bar' lines for some of the other files that were potentially more confusing to the reviewer than the larger cpu.c diff. So I went with a the broader patch.
Tom