Re: [U-Boot] [PATCH] drivers/net/fec_mxc.c: write mac address in init

Dear John Rigby,

In message 1283976684-30754-1-git-send-email-john.rigby@linaro.org you wrote:

call fec_set_hwaddr in init routine to setup MAC address so when ethaddr is set late the change will propagate to the hw

s/late/later/ ?

Signed-off-by: John Rigby john.rigby@linaro.org

drivers/net/fec_mxc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 2d4ffed..050c0e1 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -414,6 +414,8 @@ static int fec_init(struct eth_device *dev, bd_t* bd) uint32_t base; struct fec_priv *fec = (struct fec_priv *)dev->priv;

• /* Initialize MAC address */
• fec_set_hwaddr(dev); /*
  • reserve memory for both buffer descriptor chains at once
  • Datasheet forces the startaddress of each chain is 16 byte

Please insert blank line before comment.

Best regards,

Wolfgang Denk