On Wed, Jul 26, 2023 at 11:41:42AM -0500, Andrew Davis wrote:
On 7/26/23 11:21 AM, Tom Rini wrote:
On Wed, Jul 26, 2023 at 09:59:16AM -0500, Andrew Davis wrote:
On 7/25/23 5:45 PM, Tom Rini wrote:
On Tue, Jul 25, 2023 at 05:00:15PM -0500, Nishanth Menon wrote:
On 17:35-20230725, Tom Rini wrote:
On Tue, Jul 25, 2023 at 01:52:53PM -0500, Nishanth Menon wrote:
[...]
> + > +Build procedure: > +---------------- > +1. Trusted Firmware-A: > + > +.. code-block:: bash > + > + $ make CROSS_COMPILE=aarch64-none-linux-gnu- ARCH=aarch64 PLAT=k3 \ > + TARGET_BOARD=lite SPD=opteed > + > +2. OP-TEE: > + > +.. code-block:: bash > + > + $ make PLATFORM=k3 CFG_ARM64_core=y CROSS_COMPILE=arm-none-linux-gnueabihf- \ > + CROSS_COMPILE64=aarch64-none-linux-gnu-
So, we have some generic wording on how to build TF-A and OP-TEE up in doc/board/ti/k3.rst. It should be made clearer if needed that unless otherwise indicated, top of tree is expected to be used for TF-A/OP-TEE and ti-linux-firmware for the ti-linux-firmware repo. Then just state that TF-A should be which of {lite|generic|j784s4} as it is a $family device. And we then drop much of the duplication here.
Also, Robert pointed out I missed K3_PM_SYSTEM_SUSPEND=1 :(
Ugh, how many platforms is that variable valid for?
None soon :)
I'm getting rid of that flag in TF-A. There is a bug blocking me right now, but after that it will be automatic. Not sure if it is worth documenting a flag that is going away..
OK. But, automatic how? What I'm getting at, from both a documentation standpoint and also how I run my labs standpoint, is that it seems like instead of having a set of TF-A and OP-TEE binaries for each TI K3 platform I have, I really need just 3 different TF-A builds (well, in reality I don't have the J784s4 stuff so just 2) and a single OP-TEE build.
If you don't have the flag K3_PM_SYSTEM_SUSPEND=1 today then some LPM modes in Linux will be unavailable, that would be the only problem, not sure if that matters to your testing.
You will need one OP-TEE per platform, for TF-A we combine some platforms into groups (generic: AM65,J7* ; lite: AM64*,AM62*). Depending on features we add in the future, even this grouping may also go away at some point, so it will match OP-TEE (one TF-A build per platform).
Ah right, there was more than one PLATFORM for OP-TEE, OK, so I do need to have a few groups of binaries, thanks. But then this also goes with what I'm talking a bit about on IRC with Nishanth about copy/pasteable build docs. Since there is a lot of re-use I really want to avoid every board having a literal copy/paste from another board as that makes it easier to gloss over minor important differences. Something about re-using via inserting blocks and setting environment variables first should help here. And I'll go so far as to say it should reside outside of doc/board/ti/ too as while I'm not going to ask TI to re-write every elses board docs, we have a lot of "build TF-A and OP-TEE" instructions today, with slight variations to them. We should improve that as much as we can.