Re: [U-Boot] [PATCH v1 1/1] fs: fat/ext4/sandbox: Deal with files > 2GB in ls and size commands

On Wed 2014-10-08 13:23:48, Suriyan Ramasami wrote:

The commands fatls/ext4ls give -ve values when dealing with files > 2GB. The commands fatsize/ext4size do not update the variable filesize for these files.

To deal with this, the functions *_size have been modified to take a second parameter of type "* off_t" which is then populated. The return value of the *_size function is then only used to determine error conditions.

Would not it be better to simply change return type of affected functions to off_t?

(If off_t is unsigned, invent signed off_t. It is still nicer than extra parameter.)