Hi Sean
+Patrick Delaunay
What about keeping spl binary in /spl directory and copying it in root directory instead ? It would avoid us to update our environment regarding your proposal.
Just a minor remark, don't forget to add maintainers in copy when sending your patch.
Either use ./scripts/get_maintainer.pl <filename> which give you the people list to send your patch to or patman which adds automatically right people in cc.
For example ./scripts/get_maintainer.pl arch/arm/mach-stm32mp/config.mk gives you :
Patrick Delaunay patrick.delaunay@st.com (maintainer:ARM STM STM32MP) Christophe Kerello christophe.kerello@st.com (maintainer:ARM STM STM32MP) Patrice Chotard patrice.chotard@st.com (maintainer:ARM STM STM32MP) Albert Aribaud albert.u.boot@aribaud.net (maintainer:ARM) uboot-stm32@st-md-mailman.stormreply.com (moderated list:ARM STM STM32MP) u-boot@lists.denx.de (open list)
Patrice
On 1/4/19 12:37 PM, Sean Nyekjær wrote:
Deploy u-boot-spl.stm32 binary in u-boot root folder like the rest of the boards. This makes it more streamlined when building in Yocto, Buildroot etc..
Signed-off-by: Sean Nyekjaer sean.nyekjaer@prevas.dk
arch/arm/mach-stm32mp/config.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-stm32mp/config.mk b/arch/arm/mach-stm32mp/config.mk index cde5850e934..124729cd839 100644 --- a/arch/arm/mach-stm32mp/config.mk +++ b/arch/arm/mach-stm32mp/config.mk @@ -3,11 +3,11 @@ # Copyright (C) 2018, STMicroelectronics - All Rights Reserved #
-ALL-$(CONFIG_SPL_BUILD) += spl/u-boot-spl.stm32 +ALL-$(CONFIG_SPL_BUILD) += u-boot-spl.stm32
MKIMAGEFLAGS_u-boot-spl.stm32 = -T stm32image -a $(CONFIG_SPL_TEXT_BASE) -e $(CONFIG_SPL_TEXT_BASE)
-spl/u-boot-spl.stm32: MKIMAGEOUTPUT = spl/u-boot-spl.stm32.log +u-boot-spl.stm32: MKIMAGEOUTPUT = u-boot-spl.stm32.log
-spl/u-boot-spl.stm32: spl/u-boot-spl.bin FORCE +u-boot-spl.stm32: spl/u-boot-spl.bin FORCE $(call if_changed,mkimage)