Re: [U-Boot] [PATCH 1/3] sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option

On Tue, Nov 6, 2018 at 8:13 PM Chen-Yu Tsai wens@csie.org wrote:

On Wed, Nov 7, 2018 at 11:59 AM Vasily Khoruzhick anarsoul@gmail.com wrote:

...

A64 doesn't have a mode switch in CCM, so introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option to support new clock mode on A64

Signed-off-by: Vasily Khoruzhick anarsoul@gmail.com Tested-by: Zhaofeng Li hello@zhaofeng.li

This patch isn't strictly necessary. See

https://elixir.bootlin.com/linux/v4.20-rc1/source/drivers/mmc/host/sunxi-mmc.c#L831

If the switch doesn't exist, changes to that bit are ignored.

CCM_MMC_CTRL_MODE_SEL_NEW is not defined on A64, so it won't compile unless we define it on A64 which seems to be redundant.

ChenYu