Hi Miquel, Simon,
Hi,
On 18 June 2018 at 03:47, Miquel Raynal miquel.raynal@bootlin.com wrote:
Hi Martin,
Nevertheless one question: Why did you define another dts binding instead of using that one what is already available on the Linux kernel? There is "tcg,tpm_tis-spi" already defined.
I did not know this one, actually I mostly worked on U-Boot.
However, this compatible is misleading as it does not make any
difference
between v1.x and v2.0 specification.
But on the other hand it would give us a chance to determine the version
at
runtime what could be beneficial for firmware updates. But this is a
special case.
We already discussed that point on the ML and decided to choose the version at compile time. I did not have the firmware update case in mind though.
I think we need to move to determining the version at run-time, allowing people to build U-Boot with both versions if needed. This will be helpful for testing in particular.
Also I would prefer to determine the version at runtime. I will check this with two different firmware versions of SLB9670 (for TPM 1.2 and 2.0).
Regards Martin
Regards, Simon