Hi Rasmus,
On Thu, 27 Feb 2020 at 00:18, Rasmus Villemoes rasmus.villemoes@prevas.dk wrote:
Some init functions, e.g. print_resetinfo(), are conditionally defined depending on some config options, and are correspondingly conditionally included in the init_sequence_f[] array.
Others are unconditionally defined and included in init_sequence_f[], but have their entire body, sans a mandatory "return 0", conditionally compiled.
For the simple cases, switch to the former model, making it a bit more consistent. This also makes the U-Boot image very slightly smaller and avoids a few useless calls to no-op functions during board_init_f.
Can you check if it definitely does change the size? The reason I ask is that it inlines those function calls in the normal case, at least from my inspection.
Using if() is preferable to #if if there is no cost.
Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk
common/board_f.c | 54 ++++++++++++++++++++++++++++++++---------------- 1 file changed, 36 insertions(+), 18 deletions(-)
Regards, Simon