On Tuesday, September 16, 2014 at 12:33:02 PM, Michal Simek wrote:
On 09/16/2014 12:12 PM, Marek Vasut wrote:
On Tuesday, September 16, 2014 at 11:42:00 AM, Michal Simek wrote:
On 09/15/2014 01:06 PM, Marek Vasut wrote:
From: Pavel Machek pavel@denx.de
Add code necessary to program the FPGA part of SoCFPGA from U-Boot with an RBF blob. This patch also integrates the code into the FPGA driver framework in U-Boot so it can be used via the 'fpga' command.
Signed-off-by: Pavel Machek pavel@denx.de Signed-off-by: Marek Vasut marex@denx.de Cc: Chin Liang See clsee@altera.com Cc: Dinh Nguyen dinguyen@altera.com Cc: Albert Aribaud albert.u.boot@aribaud.net Cc: Tom Rini trini@ti.com Cc: Wolfgang Denk wd@denx.de Cc: Pavel Machek pavel@denx.de
arch/arm/cpu/armv7/socfpga/Makefile | 3 +- arch/arm/cpu/armv7/socfpga/fpga_manager.c | 354 +++++++++++++++++++++++
We have drivers/fpga and you should move this driver there to be visible for others. Maybe also nios can use this driver with some changes.
Good point about the move, but how could NIOS possibly use this ?
I don't know the architecture but I expect that this fpga_manager can also work with partial bitstream. It means the flow is.
- load full bitstream with NIOS
- NIOS become security manager and own this driver
- NIOS is able to load partial bitstreams via this device.
Not sure if this realistic flow on socfpga but this is possible to do on our fpga. That's why IMHO this driver should be in drivers/fpga.
Also look at my xilinx fpga changes I have done recently and you should change that altera code to look the same and remove that ugly ifdef mess.
I did clean that up to a certain degree. It was truly hideous. Who's picking up the patches for drivers/fpga/ nowadays ?
Best regards, Marek Vasut