Dear Macpaul Lin,
In message 1302590733-23912-2-git-send-email-macpaul@andestech.com you wrote:
Faraday's ftide020_s is an IDE-AHB controller for SoC design. This patch add the u-boot driver (PIO) of ftide020 ATA (IDE) driver. IDE commands include read, info, and other functions has been implemented.
Because this IDE controller support AHB interface only which is differ from other most IDE controller supports PCI interface. Some registers access is required during CMD/DATA I/O. Hence a configuration "CONFIG_IDE_AHB" is required to be defined according to the feature in cmd_ide.c.
Signed-off-by: Macpaul Lin macpaul@andestech.com
Changes for v2:
- replace default PIO mode from 0 to 4.
- clean up lines exceed 80 charecters as could as possible.
Please clean up the remaining ones, too.
+#define FTIDE_DRIVER_VERSION "1.0.1"
Can we get rid of this? Experience is that nobody ever updates this field when making changes to that file, so it's worthless.
+#ifndef TRUE +#define TRUE 1 +#endif
+#ifndef FALSE +#define FALSE 0 +#endif
Please get rid of these two.
+/* DEBUG */ +#ifdef FTIDE_DEBUG
- #define P_DEBUG(fmt, args...) printf(FTIDE_IP_NAME ":" fmt, ## args)
+#else
- #define P_DEBUG(a...)
+#endif
Can you please use debug() instead?
Best regards,
Wolfgang Denk