Re: [U-Boot] [PATCH] ppc4xx: Canyonlands: Fix USB host PHY reset sequence

Dear Stefan,

In message 1260821359-8705-1-git-send-email-dmitchell@appliedmicro.com Dave Mitchell wrote: ...

--- a/board/amcc/canyonlands/canyonlands.c +++ b/board/amcc/canyonlands/canyonlands.c @@ -177,8 +177,11 @@ int board_early_init_f(void) /* Remove NOR-FLASH, NAND-FLASH & EEPROM hardware write protection */ out_8((void *)CONFIG_SYS_BCSR_BASE + 5, 0);

• /* Enable USB host & USB-OTG */

• /* Enable USB host & USB-OTG;force assert,then de-assert PHY reset */
• out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 1);
• mdelay(100); out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 0);
• mdealy(100);

We should get rid of this "CONFIG_SYS_BCSR_BASE + offset" stuff and use a proper C struct for this. What do you think?

Best regards,

Wolfgang Denk