Hi Simon,
On 01.09.2015 17:30, Simon Glass wrote:
So my main question is, why don't you use fdt_translate_address() from fdt_support.c instead of implementing your own translation function simple_bus_translate()? Is this a size question because this may be used in SPL as well?
The attached small patch demonstrates the usage of fdt_translate_address() and enables bus translation on the MVEBU platforms.
Thanks for digging into this.
One concern I have is fdt_parent_offset(). That function is very slow
- we should use dev->parent->of_offset instead with driver model.
Other than that I think this is fine. But yes it should be enabled by CONFIG because the code size gets a lot larger and many platforms don't need it. Perhaps we should have a new CONFIG_SPL_OF_TRANSLATE?
Okay. I'll try to prepare a patch for this tomorrow. Stay tuned... ;)
Thanks, Stefan