On 11/20/2013 03:01 PM, Tom Rini wrote:
On Wed, Nov 20, 2013 at 02:53:31PM +0100, Michal Simek wrote:
On 11/20/2013 02:49 PM, Tom Rini wrote:
On Wed, Nov 20, 2013 at 08:59:43AM +0100, Michal Simek wrote:
On 11/19/2013 09:07 PM, Tom Rini wrote:
On Tue, Nov 19, 2013 at 10:09:44AM +0100, Michal Simek wrote:
Hi Albert,
I have just bisect why on the latest kernel hello world example doesn't work and I have end up in this patch too. After reverting hello world example is working.
Also I would like to know if we have still bootm support for standlone http://www.denx.de/wiki/view/DULG/UBootStandalone#Section_5.12.3. Because it is not working for me with error "ERROR: booting os 'U-Boot' (17) is not supported" and I can't see IH_OS_U_BOOT in boot_os table in cmd_bootm.c
I have created image like this. ./tools/mkimage -n "hello" -A arm -O u-boot -T standalone -C none -a c100000 -d examples/standalone/hello_world.bin -v /tftpboot/hello.ub
Let's get Albert on CC here, since, yeah, this is a problem...
This is not just arm specific problem. I see the same problem on Microblaze too. Was the support removed or just not tested and something broke it?
Can you bisect down to where this breaks on microblaze?
I even don't know if this has ever worked on Microblaze. The best will be if we can get any input from Denx before someone dive to it. They should be aware when this was working and on which arch/board.
Well, if you jump back to v2013.01 you should be well before any of this happened. If it works there, try releases up to the last to find the bisect range. If 2013.01 fails then, OK, different problem.
ok. It happened between 2013.04 and 2013.07 by the patch from Simon below. I have to run now that's why I can't look what exactly it is wrong.
Thanks, Michal
35fc84fa1ff51e15ecd3e464dac87eb105ffed30 is the first bad commit commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 Author: Simon Glass sjg@chromium.org Date: Tue Jun 11 11:14:47 2013 -0700
Refactor the bootm command to reduce code duplication
At present the bootm code is mostly duplicated for the plain 'bootm' command and its sub-command variant. This makes the code harder to maintain and means that changes must be made to several places.
Introduce do_bootm_states() which performs selected portions of the bootm work, so that both plain 'bootm' and 'bootm <sub_command>' can use the same code.
Additional duplication exists in bootz, so tidy that up as well. This is not intended to change behaviour, apart from minor fixes where the previously-duplicated code missed some chunks of code.
Signed-off-by: Simon Glass sjg@chromium.org
:040000 040000 d474a190a80c65a99484351c6021ba4f25904025 27382e1ba0944a264044075e01fe99d83852c56e M common :040000 040000 48e1b21b4ad811a0aa718d52253fb264f31b9ffb 82c78cb1928c5288cbbc651fa01b9588b3f26ac7 M include