Re: [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block

Hi!

...

...

• case (USB_REQ_GET_DESCRIPTOR << 8) | USB_DIR_IN | USB_TYPE_CLASS:
• {

• __u32 temp = 0x00000001;
  

temp is never writtenn to. Can you just write 1 instead of it?

I added a comment. This is the root port config, so it should be tweakable in case there is some mutated DWC2 core.

Ok.

...

...

• /* TODO: no endless loop */
  

• while (1) {
  

• 	hcint_new = readl(&hc_regs->hcint);
  

• 	if (hcint != hcint_new)
  

• 		hcint = hcint_new;
  

What is going on here?

What do you mean ? The loop ?

hcint is set to hcint_new in rather interesting way. The if() should not be needed, but maybe something else is wrong with the code.

Best regards, Pavel