11 Feb
2019
11 Feb
'19
9:33 a.m.
On 03.02.19 14:15, Baruch Siach wrote:
The PCIe slot PERST signal is active low. Fix the gpio signal description in the dts.
This happened to work because the pcie_dw_mvebu driver sets the reset gpio level to 1 (high) to release the reset. The following commit will fix that.
Signed-off-by: Baruch Siach baruch@tkos.co.il
arch/arm/dts/armada-8040-mcbin.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/armada-8040-mcbin.dts b/arch/arm/dts/armada-8040-mcbin.dts index 7e8e2f707ccf..5a046d9de474 100644 --- a/arch/arm/dts/armada-8040-mcbin.dts +++ b/arch/arm/dts/armada-8040-mcbin.dts @@ -132,7 +132,7 @@ num-lanes = <4>; pinctrl-names = "default"; pinctrl-0 = <&cpm_pcie_reset_pins>;
- marvell,reset-gpio = <&cpm_gpio1 20 GPIO_ACTIVE_HIGH>; /* GPIO[52] */
- marvell,reset-gpio = <&cpm_gpio1 20 GPIO_ACTIVE_LOW>; /* GPIO[52] */ status = "okay"; };
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan