On Sat, Feb 24, 2018 at 09:29:02AM -0600, Derald D. Woods wrote:
On Sat, Feb 24, 2018 at 09:35:43AM -0500, Tom Rini wrote:
On Sat, Feb 24, 2018 at 08:09:39AM -0600, Derald D. Woods wrote:
This short series is an attempt to make this set of boards use the same default configuration items where possible. This was prompted by an investigation into enabling SERIAL_SEARCH_ALL on omap3_evm. This feature now works for omap3_evm after this series.
The series changes the default NAND layout of MTDPARTS_DEFAULT and uses ENV_IS_IN_FAT. More detail is provided with the patches. As most things are configurable now, this should not be an issue. I am trying to get simple defaults that just boot and expose the common core features. This will make future testing and maintenance a bit more predictable, as there will be a very similar comparable set of boards.
I was thinking, wouldn't we want to update the beagle code now to do env in NAND on beagleboard and env on FAT on xM? We could provide a new env_get_location() to return the right location based on board. Thanks!
I thought of that too. xM can never use NAND. So FAT is always right for it. Regular BeagleBoard(3530) can have the environment in either location. Configuration can simply handle the user preference. I did not see a reason to add any more logic into an already heavy board file. The Overo boards are equally heavy with board type logic. For now, my thinking was to allow configuration do the work.
OK, but on the other hand, xM must have an SD card inserted and vanilla does not require an SD card. So now those users need to put in an SD card. Now, I honestly don't know how big a deal that is really, so I won't nak the patches. But I do think it would be the best user experience to have classic continue to work as-is and xM to finally get functional env.