Re: [U-Boot] [PATCH 6/8] arm, davinci, am1808: add lowlevel functions for booting from NOR

Hello Christian,

Christian Riesch wrote:

Heiko, I am looking forward to see these patches in mainline u-boot. My custom board also directly boots from NOR, so I think there is a lot I can re-use for my board.

Thats the goal ;-)

I have one question, please see below:

[...]

...

+void am1808_lpc_transition(unsigned char pscnum, unsigned char module,

•           unsigned char domain, unsigned char state)
  

+{

[...]

...

•   /* Wait for transition to complete */
  

•   while (readl(&reg->ptstat) & (0x00000001 << domain))
  

•           ;
  

•   /* Wait and verify the state */
  

•   while ((readl(mdstat) & 0x1F) != state)
  

•           ;
  

+}

There is some similar code in arch/arm/cpu/arm926ejs/davinci/psc.c. Is there any reason why you don't use this code or adapt it for your needs?

No, there is no reason, just missed it! I try the functions in arch/arm/cpu/arm926ejs/davinci/psc.c and if they work, I remove the am1808_lpc_transition function.

Thanks!

bye, Heiko